-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libsForQt5.plasmaMobileGear: 21.08 -> 22.04 #153329
Conversation
The reason @mjlbach @peterhoeg are pinged is because neochat is being adopted into the Plasma Mobile Gear release cycle. |
Checked:
|
97705c7
to
21fab01
Compare
Building against the last good nixos-unstable c07b471 Huh, things were working 25 days ago... but now for
Reverting 5c09fe1 fixes the build; I must suspect the benign upgrade changed something in the packaging of qcoro. Cause of the issues: No relevant fix in spacebar yet. Not an appropriate fix, but breadcrumbs to fix: diff --git a/pkgs/applications/plasma-mobile/spacebar.nix b/pkgs/applications/plasma-mobile/spacebar.nix
index 24e2f6f4715..f1ad3b3b646 100644
--- a/pkgs/applications/plasma-mobile/spacebar.nix
+++ b/pkgs/applications/plasma-mobile/spacebar.nix
@@ -38,6 +38,12 @@ mkDerivation rec {
qtquickcontrols2
];
+ # https://github.com/danvratil/qcoro/commit/8df72d3ac347615980fa5100c6f5a205bbb72b8d
+ postPatch = ''
+ sed -i -e 's;QCoro REQUIRED;QCoro5 REQUIRED COMPONENTS Core Network DBus;g' CMakeLists.txt
+ sed -i -e 's;QCoro::QCoro;QCoro5::;g' src/CMakeLists.txt
+ '';
+
meta = with lib; {
description = "SMS application for Plasma Mobile";
homepage = "https://invent.kde.org/plasma-mobile/spacebar"; |
21fab01
to
cb0ed51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff LGTM, if I find some time I might try building and running this on my pinephone.
qcoro is broken, that's a shame...
Build failure in audiotube:
audiotube> /build/audiotube-22.04/build/src/audiotube_autogen/EWIEGA46WW/../../../../src/multiiterableview.h:9:10: fatal error: span: No such file or directory
audiotube> 9 | #include <span>
audiotube> | ^~~~~~
audiotube> compilation terminated.
audiotube> make[2]: *** [src/CMakeFiles/audiotube.dir/build.make:89: src/CMakeFiles/audiotube.dir/audiotube_autogen/mocs_compilation.cpp.o] Error 1
Angelfish build is also broken
Will try to build everything tonight, hopefully can report back tomorrow or the day after. (No need to hold up merging)
Aww, OOM killer killed the build, retrying...
Result of 36 packages marked as broken and skipped:
22 packages built:
|
Result of 42 packages marked as broken and skipped:
2 packages failed to build:
14 packages built:
|
8a4b98d
to
34da6a8
Compare
Heh, does just adding gcc11 work? I wouldn't expect so... |
@ofborg build libsForQt515.audiotube |
I think we want to use gcc11Stdenv instead. |
It does:
I don't know how because of the special |
So the diff LGTM, not sure if can properly test otherwise since I'm having trouble with getting any useful output when trying to enable a display manager. It's probably due to an unrelated bug somewhere :(. Just to have it noted somewhere, for some reason the users belonging to the modules (sddm, lightdm) are not created at all... Thanks a lot for taking care of these packages! |
Result of 32 packages marked as broken and skipped:
20 packages built:
|
@samueldr Any objection to me merging this? |
34da6a8
to
7959f24
Compare
@andrevmatos Do you want me to add you as maintainer of something? |
@dotlambda I just tried my hand on this update to split the fixes broken by my try at #173266 ; eventually, I'd like to join @NixOS/qt-kde , as like to help keep KDE packages up to date; I don't have a direct interest on any specific package on this PR, but feel free to pull me in however I can help =) |
Motivation for this change
https://plasma-mobile.org/2021/12/07/plasma-mobile-gear-21-12/
https://plasma-mobile.org/2022/02/09/plasma-mobile-gear-22-02/
https://plasma-mobile.org/2022/04/26/plasma-mobile-gear-22-04/
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notescc @NixOS/qt-kde